search

ahmadjavedse / sqlalchemy-paginator

MIT License
21 stars 16 forks source link

Found an issue with a bug in sqlalchemy 1.4 that will cause an issue with this paginator #10

Open porschelau opened 3 years ago

porschelau commented 3 years ago

https://github.com/sqlalchemy/sqlalchemy/issues/6231

porschelau commented 3 years ago

the changes in 1.4 will not be compatible. https://docs.sqlalchemy.org/en/14/changelog/migration_14.html#many-core-and-orm-statement-objects-now-perform-much-of-their-construction-and-validation-in-the-compile-phase

williamjmorenor commented 3 years ago

Also:

/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/sqlalchemy_paginator/paginator.py:176: RemovedIn20Warning: The "columns" argument to Select.with_only_columns() is now passed as a series of positional elements, rather than as a list. (Background on SQLAlchemy 2.0 at: http://sqlalche.me/e/b8d9) count_query = self.optional_count_query_set.statement.with_only_columns([func.count()])