search

ahmadnassri / action-dependabot-auto-merge

Automatically merge Dependabot PRs when version comparison is within range
MIT License
342 stars 48 forks source link

Merge not merging #112

Closed cujarrett closed 2 years ago

cujarrett commented 2 years ago

What

I am trying to set up auto merge in one of my repos and seeing it almost work but then not merge.

My config:

name: auto-merge

on: [pull_request_target]

jobs:
  auto-merge:
    name: auto-merge
    needs: test
    runs-on: ubuntu-latest
    # Guarantee that commit comes from Dependabot (don't blindly trust external GitHub Actions)
    if: github.actor == 'dependabot[bot]'
    steps:
      - uses: actions/checkout@v2
      - uses: ahmadnassri/action-dependabot-auto-merge@v2
        with:
          target: minor # includes patch updates
          github-token: ${{ secrets.DEPENDABOT_AUTO_MERGE_GH_TOKEN }}

Example PR: https://github.com/cujarrett/destiny-insights-bot/pull/230

I see things that look positive like

Dependabot will merge this PR once CI passes on it, as requested by @cujarrett.

and 

@dependabot merge

But the PR is still open.

@ahmadnassri - Any thoughts?

cujarrett commented 2 years ago

My issue was w/ squash and merge.

@dependabot squash and merge works after I added that to the config.