search

ahmadnassri / action-dependabot-auto-merge

Automatically merge Dependabot PRs when version comparison is within range
MIT License
341 stars 48 forks source link

Add docker multi arch images #147

Closed bdovaz closed 1 year ago

bdovaz commented 2 years ago

146

bdovaz commented 1 year ago

@ahmadnassri bump!

Can you merge this, please?

ahmadnassri commented 1 year ago

:tada: This PR is included in version 2.6.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

bdovaz commented 1 year ago

@ahmadnassri you need to increase timeout value:

https://github.com/ahmadnassri/action-dependabot-auto-merge/blob/master/.github/workflows/push.yml#L159

It seems to take more than 5 minutes to add more platforms and causes it to fail.

ahmadnassri commented 1 year ago

indeed. I'm on a train heading to my office, will update it once I'm there

bdovaz commented 1 year ago

Reminder of that timeout issue

ahmadnassri commented 1 year ago

sorry for taking too long, I've been down with covid ...

also, for whatever reason the builds get stuck on arm/v6 and arm/v7 (see here) no matter how generous the time out is ...

I've now limited them to amd64 & arm64 just to keep this moving... (build takes less than 2 minutes)

bdovaz commented 1 year ago

In my case its ok with arm64 the rest I added them to have more compatibility with arm.

You need to upload the new image to docker hub, right? The last one on registry right now is 2.6.3

ahmadnassri commented 1 year ago

use the ghcr.io version: https://github.com/ahmadnassri/action-dependabot-auto-merge/pkgs/container/action-dependabot-auto-merge

ahmadnassri commented 1 year ago

I'm also working on v3 rewrite that doesn't use docker at all, and includes many improvements