Will it only merge if all CI passes?

ahmadnassri / action-dependabot-auto-merge

Automatically merge Dependabot PRs when version comparison is within range

MIT License

342 stars 48 forks source link

Will it only merge if all CI passes? #3

Closed peterbe closed 4 years ago

peterbe commented 4 years ago

I'm guessing the answer is yes but I want to be absolutely sure. Sorry if this is more of a support question than an actual issue, but to remedy that: The README doesn't mention if this depends on CI passing entirely. :)

ahmadnassri commented 4 years ago

yes, thankfully this is something @dependabot merge does internally, so if any "check" (a.k.a jobs & steps) fail, it wont merge.

ahmadnassri commented 4 years ago

also, if you feel you can better indicate this in the README for another future user, a PR would be great! ❤️

ahmadnassri commented 4 years ago

this is bizarly not documented anywhere on github's new docs site, and dependabot's old blog posts from before acquisition have conflicting messages...

here's a screenshot of how dependabot wont merge with failed checks: