search

ahmadnassri / action-dependabot-auto-merge

Automatically merge Dependabot PRs when version comparison is within range
MIT License
342 stars 48 forks source link

Multiple Targets #4

Closed ttshivers closed 4 years ago

ttshivers commented 4 years ago

The current behavior is that the target must match exactly for the action to auto merge. For example, if you set target to minor, it will only auto merge minor PRs and not patch PRs. I could see this as being the intended behavior

The way I get it to work is by using the action multiple times.

    steps:
      - uses: ahmadnassri/action-dependabot-auto-merge@v1.1.0
        with:
          target: patch
      - uses: ahmadnassri/action-dependabot-auto-merge@v1.1.0
        with:
          target: minor

It works fine with invoking this action multiple times but would you consider adding the ability to add multiple targets or an option to make it auto merge PRs with versions less than or equal to target?

ahmadnassri commented 4 years ago

hmm yes, good catch, I'd say this is a bug, since the intended use-case is you described

I'm using semver.diff to determine what the change is ... I guess I have to do a secondary comparison to intended target as well

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 1.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: