ahmadnassri / echint

Quick validation of files against EditorConfig
https://www.npmjs.com/package/echint
ISC License
16 stars 6 forks source link

fix(core): bad image deafault ignore pattern #68

Closed stefanmaric closed 7 years ago

stefanmaric commented 7 years ago

See #67

stefanmaric commented 7 years ago

I would personally not merge this one and actually remove that images pattern from the default ignore list.

Actually, I would personally remove all default ignoring patterns and point out in the docs to configure it yourselves, and bump a major version.

It would reduce complexity to decide what files to check since it would not have to check if user requested to hint a file ignored by default.

ahmadnassri commented 7 years ago

@stefanmaric

Actually, I would personally remove all default ignoring patterns and point out in the docs to configure it yourselves

I agree on principle, though binaries should never be checked anyways, even if user didn't filter them, since they are not applicable for this utility, same goes for "known" folders, such as node_modules, etc ...