search

ahmadnassri / node-metalsmith-pug

Metalsmith plugin to convert jade files
https://www.npmjs.com/package/metalsmith-pug
MIT License
21 stars 10 forks source link

handling errors properly #62

Open AndyOGo opened 7 years ago

AndyOGo commented 7 years ago

fixes #61

ahmadnassri commented 7 years ago

need to add a test as well.

AndyOGo commented 7 years ago

here you go, a simple test to check if err is truthy

AndyOGo commented 7 years ago

@ahmadnassri Are you happy with this PR? If you insist on your suggestions, I really recommend not to do it for the above reasons. Otherwise it's your baby, so I could still change it. For me it is very important to get this out asap.