search

ahmed-wagdi / angular-joyride

A lightweight joyride directive for giving tours of your AngularJs application
MIT License
17 stars 9 forks source link

Fix bug when step's selector doesn't exist. #12

Closed mattgrande closed 7 years ago

mattgrande commented 7 years ago

I came across a situation where the Joyride was expecting an element to exist... but it didn't. What happened was the joyride just failed, and the screen stayed grey'd out.

This commit changes that behaviour to display the 'element' step as if it was a 'Regular' step.

mattgrande commented 7 years ago

Yep, no problem. I'll get to them in a few hours.

mattgrande commented 7 years ago

I changed my mind and opted to do it now :) Let me know if you have any other comments/concerns.

mattgrande commented 7 years ago

Thanks for merging this! Are you planning on doing another release anytime soon?

ahmed-wagdi commented 7 years ago

No problem, i appreciate any help i can get :)

I published the changes you made to make sure people get the updated version.