ahmed-wagdi / angular-joyride

A lightweight joyride directive for giving tours of your AngularJs application
MIT License
17 stars 9 forks source link

Joyride positioned offscreen (#2) #14

Closed steve-tapley closed 7 years ago

steve-tapley commented 7 years ago

Hi, This is related to #13 , but now an item at the top is off the screen

See the plunkr for an example: https://plnkr.co/edit/WUKd9diJaCoeJbhwjLWe?p=preview

Cheers, Steve

ahmed-wagdi commented 7 years ago

Alright that shouldn't be a problem to fix but it might take me a few days to get to it.

steve-tapley commented 7 years ago

My hacky fix for this was in the setPos() function, approx line 328

if (position.top < 0) { var triangle = document.querySelector(".jr_container .triangle"); triangle.style.top = (position.top * 2) + 'px'; position.top = 0; }

ahmed-wagdi commented 7 years ago

Updated the package, it should be working now.