ahmed-wagdi / angular-joyride

A lightweight joyride directive for giving tours of your AngularJs application
MIT License
17 stars 9 forks source link

Responsive should allow different selector #16

Closed Deklin closed 7 years ago

Deklin commented 7 years ago

We have a situation where when in large screen mode an element is on the screen, however once the screen collapses down, it changes to a button with a different locator. Consider adding a different selector to responsive mode.

ahmed-wagdi commented 7 years ago

I would rather not overcomplicate the directive by trying to handle every single case. This problem can be resolved easily by adding a resize event handler on the window and just change the steps array as you like at certain breakpoints.

You should be able to handle all responsive issues this way, the only reason i added a responsive placement feature was because it's a very common problem so i thought i'd just make it easier but even that could be resolved by utilizing the resize event.