search

ahmed-wagdi / angular-joyride

A lightweight joyride directive for giving tours of your AngularJs application
MIT License
17 stars 9 forks source link

Popup is scroll to the top of page, causing some of the highlighted content to overflow from the screen #4

Closed cjb5333 closed 7 years ago

cjb5333 commented 7 years ago

Your directive is very helpful - helped me escape a jquery dependency on other directive :)

When using left and right positions, the popup scrolls to top; however, since the popup is centered on the element and the top of the element extends past the top of the popup, it is cut off the screen.

I'm not sure if i'm doing something wrong or if this should be an issue, thanks!

ahmed-wagdi commented 7 years ago

I'm glad you found it helpful :)

Could you send a screenshot of the problem?

cjb5333 commented 7 years ago

I took 2 screenshots, but had to remove any PI.

This is the full element, and how I would expect it to be position with respect to the top of the page. In this screenshot, the top of the image is the top of the screen: angular-joyride_good

This is the screenshot of how it actually renders and where it scrolls to. Again, the top of the image is the top of the screen, and you can see that the top part of the element from the previous screenshot is hidden and off the page: angular-joyride_bad

ahmed-wagdi commented 7 years ago

So you're saying that the the window scrolls to the top of the joyride popup but it should be scrolling to the top of the highlighted element instead correct?

If that's the case then i'm not really getting the same issue, i created a plunkr here where it seems to be working fine: https://plnkr.co/edit/OagapaIJ5GxO1QKHTqNj?p=preview