ahmedKanoun / sipservlets

Automatically exported from code.google.com/p/sipservlets
0 stars 0 forks source link

ProxyBranch.cancel is not sending CANCEL if a PRACK has been used #253

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a servlet that initiates a Proxy on INVITE and calls Proxy.cancel on 
CANCEL
2. Send the INVITE to the servlet
3. Send a PRACK to the servlet
4. Send a CANCEL to the servlet

What is the expected output? What do you see instead?
The calls to Proxy.cancel/ProxyBranch.cancel is expected to send the CANCEL 
request to the next hop.

But, nothing happens, no exception, no logs.

What version of the product are you using? On what operating system?
3.0.0-SNAPSHOT

Please provide any additional information below.
According to the sources, the logic of ProxyBranch.cancel is explicitly 
verifying that the last request received was an INVITE, which is wrong in the 
case where a PRACK has been used.

Original issue reported on code.google.com by nicolas....@gmail.com on 26 Jan 2014 at 7:47

GoogleCodeExporter commented 9 years ago

Original comment by jean.deruelle on 18 Apr 2014 at 4:58

GoogleCodeExporter commented 9 years ago
Tied to Issue 33

Original comment by jean.deruelle on 18 Apr 2014 at 9:50

GoogleCodeExporter commented 9 years ago
This issue was updated by revision 6cf4aa67ba9f.

Update Issue 33

Fix + non regression test

(cherry picked from commit b42eefcee0f056474bc4a4b78a25261b2beae481)
(cherry picked from commit 9d79a49d2af4306a3275b88e124e7d80caebff88)

Original comment by jean.der...@telestax.com on 25 Apr 2014 at 9:40

GoogleCodeExporter commented 9 years ago
This issue was updated by revision 3966450cbecf.

Update Issue 33

adding UPDATE as well

(cherry picked from commit bd7611aaa9f16c62f71da23a09e909a5299324d7)

Original comment by jean.der...@telestax.com on 25 Apr 2014 at 9:40

GoogleCodeExporter commented 9 years ago

Original comment by jean.deruelle on 25 Apr 2014 at 9:43

GoogleCodeExporter commented 9 years ago

Original comment by jean.der...@telestax.com on 25 Aug 2014 at 10:52