ahmeditalia / SWE2

0 stars 0 forks source link

Code Review: Store Component #6

Open hosamr opened 6 years ago

hosamr commented 6 years ago

Feature Reviewed: Store Component

Implemented By: Italia

Design Principles

[x] Does the design follow SOLID principles?
[x] Does the design follow OOP rules?
[ ] Is the design simple and easy to modify?

Coding Standards

[x] Is the code understandable and readable?
[ ] Does the code follow Java Coding Style?
[x] Is indentation used properly?
[x] Do variable have good names?

Comments

[ ] Is the code commented enough?
[ ] Is every class and method commented?
[ ] Do comments follow Javadoc style?
[ ] Is Javadoc generated for all the code?
[ ] Are there useless / wrong comments?

Code Structure

[ ] Does the code follow the design precisely?
[x] Are there very long classes or methods?
[ ] Is there repeated code ?

Error Handling

[ ] Does the code handle errors and exceptions?
[ ] Is defensive programming used to avoid errors?

Logic

[x] Do loops have correct conditions and bounds?
[x] Do loops always terminate?

Overall

[x] Are the design and code of good quality?

hosamr commented 6 years ago

The code is well and follows the design but my problem with it is the StoreController class being tall. I Know it is hard to shorten it but could you look for ways as to separate it in a better manner?

Otherwise 3ash ya rgala [:D]