search

ahmedmaher05 / LLG-MP

Language Learning Gamification Media Player
https://ahmedmaher09.github.io/LLG-MP/
27 stars 7 forks source link

Mac OS support #18

Open colossatr0n opened 2 years ago

colossatr0n commented 2 years ago

Just putting in an enhancement request to add Mac OS support.

Since this is an electron-app, what exactly does this conversion entail? Does the actual logic of LLG-MP need to be changed, or is it mostly build and dependency stuff?

colossatr0n commented 2 years ago

I actually started working on a feature branch and have it running now. I'll see if I can flesh out the rest of the branch and then I'll submit a PR for Mac OS support.

ahmedmaher05 commented 2 years ago

No major stuff, Mostly dependencies indeed.

great job @colossatr0n , the merge works successfully but has some minor conflicts with regression testing for some other features. kindly provide your email/skype or join the Gitter chat link in the README.md section if you are free to give me a hand in solving the regression test issues together. nevertheless, I will work on it ASAP if you were busy.

colossatr0n commented 2 years ago

Thank you! I just joined the Gitter chatroom.

ahmedmaher05 commented 2 years ago

Great, gonna catch up with you there in a while

colossatr0n commented 2 years ago

Fixed some more issues with the PR. Hopefully that'll resolve some of those regressions.