search

ahmednuaman / grunt-scss-lint

A Grunt task to lint your SCSS
MIT License
142 stars 35 forks source link

Adding output of number of files inspected in case of failing #117

Closed barzik closed 8 years ago

barzik commented 9 years ago

I've needed output of the number of files linted, so I've added fileReport option. if someone is setting it to true, The report will include the numbers of files that were inspected. I've also added test spec for this.

ahmednuaman commented 9 years ago

Care to fix please?

barzik commented 9 years ago

The build is broken by Lint errors (not created by my code). Do you prefer me to insert the fixes in this pull request or to create another pull request?

ahmednuaman commented 9 years ago

It looks like they are your code errors. I can only merge this PR when the builds are passing.

barzik commented 9 years ago

You are very right about the lint issues (sorry about that!). But please look on the Travis CI failed. it failed because of time out issues for other test. Can you provide input for handling it?

ahmednuaman commented 9 years ago

Not sure, haven't seen that before. Did you sort your hinting out?

barzik commented 9 years ago

It seems that some of tests are experienced time out issues. it is not relevant to the code itself. you can see that the build failed in this pull request, although the file that was changed is only readme file: https://github.com/ahmednuaman/grunt-scss-lint/pull/120

I have trouble to reproduce it in my main dev machine, but I have slower machine that it happens there as well. temporary solution will be pushing up the timeout level. But We need to take a closer look on the tests.

ahmednuaman commented 8 years ago

Any news on this?