search

ahmednuaman / grunt-scss-lint

A Grunt task to lint your SCSS
MIT License
142 stars 35 forks source link

Change gem name from scss-lint to scss_lint in README.md #124

Closed chrisnicotera closed 8 years ago

chrisnicotera commented 9 years ago

Although the project is still named scss-lint, the Gem is now named scss_lint.

I assume scss-lint is left in place for legacy purposes, as it seems to have changed ownership from causes to brigade. The last release of scss-lint (causes) is 0.38.0, from May 3, 2015.

ahmednuaman commented 8 years ago

What about the gemfile too?

rek commented 8 years ago

Gemfile is updated, it is confusing to not have the readme updated too.

+1

alexcanessa commented 8 years ago

@ahmednuaman could I suggest to merge this PR sooner than later?

ahmednuaman commented 8 years ago

Why are the tests failing?

chrisnicotera commented 8 years ago

@ahmednuaman https://travis-ci.org/ahmednuaman/grunt-scss-lint/jobs/80890455#L317-L324

The test didn't finish in time. This is also happening on Appveyor although with a couple of other, unrelated errors.

Perhaps consider increasing the mocha test timeout since these tests are spawning grunt and most of them are approaching the 2000ms default?

I've only modified README.md, so the tests failing for this PR is moot, but that should resolve the issue that both CI suites are experiencing.

ahmednuaman commented 8 years ago

Try to rebase and try again

chrisnicotera commented 8 years ago

@ahmednuaman Should be good to go