ahmedsuffian / aionxemu

Automatically exported from code.google.com/p/aionxemu
0 stars 0 forks source link

Greater Healing Potion doesnt dispel physical debuff. #157

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Core revision:208

Bug description:
Greater Healing Potion doesnt dispel physical debuff.

What steps will reproduce the problem?:
use Greater Healing Portion for dispeling physical debuff.

What is the expected output?:
the original dispels both physical debuff and mental debuff.

Original issue reported on code.google.com by pl6...@gmail.com on 23 Mar 2011 at 9:53

GoogleCodeExporter commented 9 years ago
for details, I couldnt dispel Flame Cage IV, Flame Fusion II, Blaze V, Erosion 
I.

Original comment by pl6...@gmail.com on 23 Mar 2011 at 10:04

GoogleCodeExporter commented 9 years ago
I believe this can be fixed in the Datapack.

Original comment by ZeroSign...@gmail.com on 23 Mar 2011 at 11:19

GoogleCodeExporter commented 9 years ago
i tried to fix it personally.
but Greater Healing Potion can dispel two effects regardless of Mental or 
Physical.
so,
void removeMentalEffect()
void removePhysicalEffect()
these methods have to return int for dispeled number.
and DispelEffect class doesnt have value param like DispelDebuffMentalEffect or 
DispelDebuffPhysicalEffect.

i cant see how should i fix this.
and i thought it might be core things so i shouldnt fix it in local boldly for 
avoiding spaghetti code and hard merging.

Original comment by pl6...@gmail.com on 23 Mar 2011 at 5:10

GoogleCodeExporter commented 9 years ago
Could you just use DispelEffect? The XML syntax is:

<dispel dispeltype="EFFECTID" e="2" element="WATER">
<effectids>114652</effectids>
<effectids>115702</effectids>
<effectids>113662</effectids>
<effectids>113582</effectids>
</dispel>

Original comment by ZeroSign...@gmail.com on 4 Apr 2011 at 2:49

GoogleCodeExporter commented 9 years ago
thx
it worked.

Original comment by pl6...@gmail.com on 4 Apr 2011 at 6:50

GoogleCodeExporter commented 9 years ago

Original comment by versi...@gmail.com on 4 Apr 2011 at 7:57

GoogleCodeExporter commented 9 years ago
Fixed Committed Revision 244.

Original comment by ZeroSign...@gmail.com on 6 Apr 2011 at 3:53