[Security] all stackable item dupe

[GoogleCodeExporter]

Core revision: 220

Bug description:
All items that can stack can be dupe.

What steps will reproduce the problem?:

1. In my example 1 have 100pcs manastone. I split into 2 so i have 1pcs and 
99pcs.

http://www.ipasarmalam.com/aa/dupe1.png

2. Start trading with other player and put the 1 pc manastone in the trade 
window.

http://www.ipasarmalam.com/aa/dupe2.png

3. Before locking. drag the 99pcs manastone in you inventory and re-stack it on 
the 1pc manastone in your inventory to make it 100pcs again.

http://www.ipasarmalam.com/aa/dupe3.png

4. Then lock the trade and voila, the other get 99pcs and you still got the 
99pcs.

http://www.ipasarmalam.com/aa/dupe4.png

What is the expected output?:

Please copy/paste errors below:

Original issue reported on code.google.com by Adik...@aionaddiction.com on 30 Mar 2011 at 6:49

[GoogleCodeExporter]

this applies to all stackable items like enchantment stones, manastone, 
godstone, shards, pots, etc...

Original comment by Adik...@aionaddiction.com on 30 Mar 2011 at 6:51

[GoogleCodeExporter]

231 trying made it with this item 
http://aion.yg.com/ru/item/волшебный-камень-ур-1?id=166000001

cant. Then not confirm.

Original comment by to...@mail.com on 31 Mar 2011 at 3:12

[GoogleCodeExporter]

your are not doing it correctly. I tried that L1 enchantment stone and it works

1. you must split the items into 2 group first.
http://www.ipasarmalam.com/aa/dupe2_1.png

2. you MUST drag the big qty over the 1 qty. Dragging 1 qty to 99qty won't dupe 
the item.

http://www.ipasarmalam.com/aa/dupe2_2.png

3. lock the trade and see the resul
http://www.ipasarmalam.com/aa/dupe2_3.png

Original comment by Adik...@aionaddiction.com on 31 Mar 2011 at 4:23

[GoogleCodeExporter]

and i can even dupe all stackable items all together. LOL

http://www.ipasarmalam.com/aa/dupe_all.png

Original comment by Adik...@aionaddiction.com on 31 Mar 2011 at 4:30

[GoogleCodeExporter]

Then i cant move 99 items to 1 because got error - "you in trade..." Then try 
use 231 clear rev and reproduce this.

Original comment by to...@mail.com on 31 Mar 2011 at 5:02

[GoogleCodeExporter]

I created a clean server Rev 231. And it's still there.

I can still dupe.

Original comment by Adik...@aionaddiction.com on 31 Mar 2011 at 5:14

[GoogleCodeExporter]

Confirm. I can do it as well. Your in trade will not so when joining the items 
back up, if you don't press SHIFT.

Original comment by ZeroSign...@gmail.com on 31 Mar 2011 at 5:15

[GoogleCodeExporter]

Original comment by ZeroSign...@gmail.com on 31 Mar 2011 at 9:14

• Changed state: Started

[GoogleCodeExporter]

Original comment by ZeroSign...@gmail.com on 31 Mar 2011 at 9:14

• Added labels: Priority-Critical
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Apply Patch, test and report results. It should cause the Trade to close when 
trying to mess with the Stacked Item in the Inventory while trading.

Original comment by ZeroSign...@gmail.com on 31 Mar 2011 at 10:55

• Changed state: Fixed

Attachments:

• PlayerExchange_Item_Stack_Dupe_Exploit_fix_1.patch

[GoogleCodeExporter]

Committed Revision 232.

Original comment by ZeroSign...@gmail.com on 31 Mar 2011 at 11:48

[GoogleCodeExporter]

thanks zero!

I will test this when i got home.

Original comment by Adik...@aionaddiction.com on 31 Mar 2011 at 12:01

[GoogleCodeExporter]

Original comment by ZeroSign...@gmail.com on 6 Apr 2011 at 2:27

• Changed state: Done