dot removes root

[GoogleCodeExporter]

Core revision:232

Bug description:
dot removes root

What steps will reproduce the problem?:
use some dot skill
use root
wait few seconds

What is the expected output?:
dot dont remove root

i fixed it in local.
please use this.

Original issue reported on code.google.com by aiongz....@gmail.com on 4 Apr 2011 at 5:40

Attachments:

• CreatureController.java

[GoogleCodeExporter]

Upload the diff/patch file.

See:
http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-patch.html

Original comment by ZeroSign...@gmail.com on 5 Apr 2011 at 2:13

• Changed state: Started

[GoogleCodeExporter]

Reverted back to Accepted. The file is not a valid diff/patch file.

Original comment by ZeroSign...@gmail.com on 20 Apr 2011 at 11:59

• Changed state: Accepted

[GoogleCodeExporter]

I've attempted to make a diff of this.
Using revision: 304

Completely untested, but it merges the changes made to the controller in the 
file above with the currently head revision, so any bugs present are either 
caused by the above file or present in the latest revision. 

Original comment by Ellipsis...@gmail.com on 5 Jun 2011 at 3:57

Attachments:

• dotfix.patch

[GoogleCodeExporter]

Please fix the indenting to 4 spaces so we may have a better idea of what you 
have changed.

Original comment by ZeroSign...@gmail.com on 5 Jun 2011 at 10:56

• Changed state: Started

[GoogleCodeExporter]

Reuploaded, and the patch looks better when I attempt to apply it.  Hopefully 
this one comes out a bit clearer. Vim didn't save my whitespace properly.

Going to delete previous version so it isn't accidentally downloaded and 
applied. All changes are the same as in the above .java file, but applied to 
revision 304, so I can't vouch for their usefulness.

Original comment by Ellipsis...@gmail.com on 5 Jun 2011 at 11:44

Attachments:

• dotfix.patch

[GoogleCodeExporter]

Patch above doesn't compile as it is missing a parameter. This duplicates a bug 
in the original source file above. However, that note is purely academic, as 
the bug is already fixed in the latest revision. Attempts to reproduce the bug 
in a relatively active server proved to be in vain.

Using revision 305, I performed the following test:
1) Casted Erosion I
2) Casted Root I
3) Wait 3 seconds
4) Observe that mob does not break free of Root.
5) Repeat steps 1 through 4, replacing Erosion I with every known DoT spell in 
the game. That is not hyperbole; it took around 3 hours to do.

In each case, the enemy took damage from the DoT, but did not break the Root.  
I should note that if you reverse this and cast the damaging spell last, the 
root will break. This seems to be intended retail behavior and will happen with 
any type of damage, even physical.

I can only assume that the bug was fixed in a previous revision. Either way, 
can safely mark it as "Fixed" now.

Original comment by Ellipsis...@gmail.com on 6 Jun 2011 at 3:44

[GoogleCodeExporter]

Marked to Fixed, if still an issue please let me know, thanks.

Original comment by ZeroSign...@gmail.com on 6 Jun 2011 at 5:00

• Changed state: Fixed

[GoogleCodeExporter]

Marked to Fixed, if still an issue please let me know, thanks.

Original comment by ZeroSign...@gmail.com on 6 Jun 2011 at 5:00