search

ahmedsuffian / aionxemu

Automatically exported from code.google.com/p/aionxemu
0 stars 0 forks source link

Reflect Effect/Stack Overflow Error #271

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Core revision: r257

Bug description: Still Reflect Effect/Stack Overflow Error, at worst case the 
whole server crash.

What steps will reproduce the problem?: You can reproduce easily if 2 players 
attacking eachother and both are buffed with reflect effect. Skills to test: 
2210 (sorc), 2058 (templar) 

What is the expected output?: I don't know how works on retail, i assume the 
reflect effect should be passive if the opponent have reflect buff too.

Please copy/paste errors below:
[ERROR 2011-04-13 00:31:25] gameserver.network.aion.AionClientPacket:71 - Error 
handling client (test) message :[C] 0x93 CM_CASTSPELL
java.lang.StackOverflowError
    at gameserver.controllers.ObserveController.notifyAttackedObservers(ObserveController.java:121)
    at gameserver.controllers.CreatureController.onAttack(CreatureController.java:141)
    at gameserver.controllers.PlayerController.onAttack(PlayerController.java:346)
    at gameserver.controllers.PlayerController.onAttack(PlayerController.java:361)
    at gameserver.controllers.CreatureController.onAttack(CreatureController.java:150)
    at gameserver.skillengine.effect.ReflectorEffect$1.attacked(ReflectorEffect.java:67)
    at gameserver.controllers.ObserveController.notifyAttackedObservers(ObserveController.java:127)

Original issue reported on code.google.com by fourthdi...@gmail.com on 13 Apr 2011 at 12:41

GoogleCodeExporter commented 9 years ago 
What's the error?

Tried this fix?
See Issue 257

Original comment by ZeroSign...@gmail.com on 14 Apr 2011 at 10:44

GoogleCodeExporter commented 9 years ago 
For any Dev who takes a look at this, the only thing I can think of is that 
somehow Observers keep on being added infinitely until an overflow occurs.

Original comment by ZeroSign...@gmail.com on 14 Apr 2011 at 11:04

GoogleCodeExporter commented 9 years ago 
i've tested with ConcurrentModificationExceptionFix.patch, still not solved.

Original comment by fourthdi...@gmail.com on 15 Apr 2011 at 12:12

GoogleCodeExporter commented 9 years ago 
both players get reflect damage from one another?

Original comment by gga...@gmail.com on 16 Apr 2011 at 6:49

GoogleCodeExporter commented 9 years ago 
yes, both players, but the problem is that when its happening the error message 
overflow and the server crash mostly, im thinking about maybe its only of the 
java, i will test it on different systems though.

Original comment by fourthdi...@gmail.com on 16 Apr 2011 at 11:33

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Use this patch. It works. I've tested it. :D

Original comment by gga...@gmail.com on 17 Apr 2011 at 9:32

Attachments:

GoogleCodeExporter commented 9 years ago 
A little modification. Use this one.

Works fine for me. :)

Original comment by gga...@gmail.com on 17 Apr 2011 at 1:32

Attachments:

GoogleCodeExporter commented 9 years ago 
Everyone please test the above thoroughly as we want to have this fixed asap.

Thanks gga...

Original comment by ZeroSign...@gmail.com on 18 Apr 2011 at 3:31

GoogleCodeExporter commented 9 years ago

Original comment by ZeroSign...@gmail.com on 18 Apr 2011 at 3:31

GoogleCodeExporter commented 9 years ago 
I confirm this on my server too, when templar and sorc or templar vs mob using 
both reflect skills server almost EXPLOTE, with this patch all working good ;)

Original comment by aion.ren...@gmail.com on 18 Apr 2011 at 5:52

GoogleCodeExporter commented 9 years ago 
the patch works fine, thank you, it's fixed.

Original comment by fourthdi...@gmail.com on 19 Apr 2011 at 8:10

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
More fix... I think Protect State should only be checked only if a protector is 
in range.

Also I wonder if Attacked Observers of the protector or the attacked player 
should be notified when a protector exists.

Please let me know.
Thanks. :)

Original comment by gga...@gmail.com on 19 Apr 2011 at 12:51

Attachments:

GoogleCodeExporter commented 9 years ago 
Issue 295 has been merged into this issue.

Original comment by ZeroSign...@gmail.com on 27 Apr 2011 at 10:43

GoogleCodeExporter commented 9 years ago 
Committed Revision 271.

Original comment by ZeroSign...@gmail.com on 27 Apr 2011 at 2:18