search

ahmedwalid05 / FastExcel

Fast Excel Reading and Writing in .Net
MIT License
335 stars 98 forks source link

Add unit tests #47

Closed rstm-sf closed 4 years ago

rstm-sf commented 4 years ago

Resolve #19

mrjono1 commented 4 years ago

thanks heaps for this PR, hopefully I'll have some time soon to check out what is going on in appVeyor

rstm-sf commented 4 years ago

MSBuild auto-detection: using msbuild version '15.9.21.664' from 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\bin'. nuget : C:\Program Files\dotnet\sdk\2.2.109\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(137,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.0. Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.0. [C:\projects\fastexcel-43v9o\FastExcel.Tests\FastExcel.Tests.csproj]

Need to change image on Visual Studio 2019. Or should I change to .NET Core 2.2 :)

mrjono1 commented 4 years ago

@rstm-sf I have fixed the build, it also released to nuget... i better do some work to stop that on open PRs

rstm-sf commented 4 years ago

@mrjono1 thanks for watching!

Regarding PR, I'm sorry, I had little time for finish. I think that in the near future I will be able to add new tests if I figure out what can be added. Or I just open PR if I can’t figure out what can be added

rstm-sf commented 4 years ago

I could not figure out how to reproduce the remaining cases

mrjono1 commented 4 years ago

Thankyou again ill review this soon