search

ahmetaa / zemberek-nlp

NLP tools for Turkish.
Other
1.15k stars 210 forks source link

Avoid main methods in library classes #116

Closed mdakin closed 6 years ago

mdakin commented 7 years ago

They are quite handy for quick testing, but in most cases there should be a separate class to test the functionality with preferably command line parameters for input/output files this would avoid user dependent or hardcoded directories in the codebase as well. In some cases unit tests are enough anyway.

mdakin commented 7 years ago

There are currently 23 main methods in the project.

https://github.com/ahmetaa/zemberek-nlp/search?utf8=%E2%9C%93&q=%22void+main%22&type=Code

ahmetaa commented 7 years ago

Agreed. This is an easy fix.

ahmetaa commented 6 years ago

This is addressed (mostly) in 0.12.0 closing it for now.