Open gjermundgaraba opened 3 years ago
WebSockets or gRPC are still HTTP requests.
Similarly, Eventarc also delivers over HTTP (in cloudevents format).
So I think the only revision needed is to add Eventarc next to Pub/Sub.
That was not really the point. And if you want to be specific about it: Only the initial opening of the websocket connection is http, everything after is not. And just because it can receive those things over HTTP doesn't mean it supports any protocol over HTTP. Cloud Functions also use HTTP, but they don't support gRPC or websocket.
The point is that the section in question is about the differences between Cloud Run and Cloud Functions. So perhaps a better way of phrasing this is to specify the different trigger types.
"Cloud Run can only receive HTTP requests or Pub/Sub push events."
This is not true anymore. Cloud Run can now accept events via WebSockets, Eventarc (which let's Cloud Run react to something akin to CloudEvents, but more specifically events from over 90 GCP services - making the distinction between Cloud Functions and Cloud Run less obvious), as well as invocations by gRPC.
https://cloud.google.com/run/docs/triggering/grpc https://cloud.google.com/eventarc/docs/overview