search

ahmetb / go-httpbin

http://httpbin.org endpoints for your Go tests
https://godoc.org/github.com/ahmetalpbalkan/go-httpbin
Apache License 2.0
124 stars 26 forks source link

Add vendor #4

Closed egorsmkv closed 7 years ago

egorsmkv commented 7 years ago

I think you should add vendoring. What do you think about govendor?

egorsmkv commented 7 years ago

And why in tests files imports github.com/ahmetalpbalkan/go-httpbin ? I can't run tests because of this.

ahmetb commented 7 years ago

We're a library, it's not very recommended for libraries to vendor libs. Plus I think we only have test dependencies (so that's not really a really dependency?) so we don't really need to vendor.

Tests are in another package so that we only test the exported methods also the ExampleXxx method shows the usage with package name included. This is a common practice, even used in stdlib.

egorsmkv commented 7 years ago

Understood.