search

ahmetb / kubectl-tree

kubectl plugin to browse Kubernetes object hierarchies as a tree 🎄 (star the repo if you are using)
Apache License 2.0
2.98k stars 122 forks source link

update actions to push new release to krew-index #11

Closed rajatjindal closed 4 years ago

rajatjindal commented 4 years ago

Update release yml to also update krew-index repo.

Also request you to please disable krew-release-bot github app to avoid sending duplicate requests.

ahmetb commented 4 years ago

This is dope. Do you want to delete the Github App altogether for everyone? That might be better.

rajatjindal commented 4 years ago

This is dope. Do you want to delete the Github App altogether for everyone? That might be better.

the bot now supports two endpoints, one for webhook and one for action.

i would think we can continue to have both and let user make a choice? personally I also liked goreleaser way of doing the release (though I am struggling to get this to work because i do not use go modules yet).

Thanks Rajat Jindal

ahmetb commented 4 years ago

I think we would advertise the GitHub action. Because it can print output/progress etc. GH App wasn’t usable at all for me and likely for many others.

rajatjindal commented 4 years ago

I think we would advertise the GitHub action. Because it can print output/progress etc. GH App wasn’t usable at all for me and likely for many others.

sure sounds good to me. I have remove the token requirement from github action.

Thanks Rajat Jindal

ahmetb commented 4 years ago

This worked like a champ image

cc: @corneliusweig

corneliusweig commented 4 years ago

Wow, this is nice!