ahmetb / kubernetes-network-policy-recipes

Example recipes for Kubernetes Network Policies that you can just copy paste
Apache License 2.0
5.69k stars 1.73k forks source link

02a-allow-all-traffic-to-an-application document correction #69

Closed kaleshas closed 3 years ago

kaleshas commented 3 years ago

READ BEFORE YOU CREATE AN ISSUE: This issue tracker is specifically about the recipes listed in this repository. If you want to ask a general question about network policies or advice, DO NOT ask them here. Instead ask them on:

I think the below lines in the example 02a-allow-all-traffic-to-an-application.md should be corrected.

------existing---

Empty ingress rule ({}) allows traffic from all pods in the current namespace, as well as other namespaces. It corresponds to:


---- should be updated to -----

Empty ingress rule ({}) allows traffic from all pods in the current namespace, as well as other namespaces. It corresponds to:


The elements in the from should be an array:

kubectl explain NetworkPolicy.spec.ingress.from KIND: NetworkPolicy VERSION: networking.k8s.io/v1

RESOURCE: from <[]Object>

ahmetb commented 3 years ago

Can you please use code blocks? It's literally a button on the code editor here. I can't understand what you're indicating. You can also send a pull request to fix it.

boredabdel commented 3 years ago

Closing, will continue the conversation in https://github.com/ahmetb/kubernetes-network-policy-recipes/pull/67