search

ahmj / LeagueSets

An extension used to create in-game item sets using guides from popular fansites such as LOKING, Mobafire, Champion.gg, and ProBuilds.
3 stars 1 forks source link

Completely updated all scripts and implemented new ones among other things! #10

Closed Zaxyul closed 5 years ago

Zaxyul commented 5 years ago

I use this extension a lot for my own personal use getting guides for league so I can think less when grabbing things in game and awhile ago I updated it personally for myself to show newly released items since it lacked updates to match League's updates and then Mobafire completely revamped their build page so I had to update that as well and at that point I figured I might as well go all out and fix it for everyone!

Here is to my recollection the full list of changes overall (I have more planned in the future when I get free time but this should be good enough for now, I hope it helps!)

  1. Removed LolKing (Site shutdown)

  2. Removed Solomid (Hasn't been updated in 2 years, so jungle, champions and items not to mention builds are HEAVILY outdated)

  3. Painstakingly updated Mobafire's item table to support all item changes since the end of Season 7 to today.

  4. Updated the Mobafire's script to work with the modern version of Mobafire (Was previously 100% broken)

  5. Updated Probuild's script to work with the modern version of the site.

  6. Updated Champion.GG's script to work with the modern version of the site.

  7. Updated the Manifest & Read-Me files to represent the latest state of the extension

  8. Fixed a bunch of various bugs

  9. And finally I implemented brand new U.GG build Support!

I hope you are okay with all of these changes and they make it through, if it helps one person out there it's worth it!

Also solving all of these allows these issues to be closed and solved:

https://github.com/ahmj/LeagueSets/issues/9

https://github.com/ahmj/LeagueSets/issues/8

https://github.com/ahmj/LeagueSets/issues/6

Let me know if you have any questions or want me to change or fix anything or what have you, I am not the best coder in the world but it's something!

(Also I have tested all of these sites on multiple champions and multiple builds with multiple different new item configurations ETC, I have yet to see any problems but if you do please let me know so I can fix it!)

ahmj commented 5 years ago

Thanks for taking the time to do this!

If I get a chance I'll try and take a look at this over the weekend

Zaxyul commented 5 years ago

I believe I resolved most of the issues in my latest commit! It is totally revised and so much more concise and less arbitrary, thanks for pointing those issues out!

Let me know if everything is looking good now (I haven't used Github in a long time I hope I did the updated commit properly for this PR).

Also it's absolutely no problem in regards to updating everything, I really loved the usage I got out of your extension and wanted others to be able to enjoy that in the future as well (as I do currently still!) thanks for all the original effort and I hope I can help keep this alive for awhile!

ahmj commented 5 years ago

Looks great, thanks for the your contribution!

I'll get to updating the release on the app store to include these changes sometime this week