search

ahn / vaadin-aceeditor

Vaadin wrapper for Ace editor
Apache License 2.0
24 stars 37 forks source link

syntax highlighting and HTTPS #24

Closed fkeusch closed 10 years ago

fkeusch commented 10 years ago

We use aceeditor vaadin plugin with syntax highlighting.

Over https syntax highlighting doesn't work. E.g. the browser blocks the following js script load over http (see browser error console)

Blocked loading mixed active content "http://d1n0x3qji82z53.cloudfront.net/src-min-noconflict/mode-sql.js" ...

The URL is hard coded and final in the class AceEditor.class (DEFAULT_ACE_PATH)

I think you could easily make this protocol-independant. By just removing the 'http' the link will work for both http and https (-> DEFAULT_ACE_PATH = "//d1n0x3qji82z53.cloudfront.net/src-min-noconflict";)

See this link for explanations: http://blog.httpwatch.com/2010/02/10/using-protocol-relative-urls-to-switch-between-http-and-https/

Kind Regards Florian

davidef commented 10 years ago

My commit a059cd26fe7b90aa2381063bcb0674651c806d6a fixes this issue and have been merged in 0.8.12 so this should be marked as fixed