ahnet-69 / treble_yaap

The patches used to build YAAP as trebledroid GSI
12 stars 2 forks source link

Can I get Magisk to flash my system.img for up to date Magisk root? #9

Closed StupidRepo closed 1 year ago

StupidRepo commented 1 year ago

Basically, if I download a system.img to my phone and get Magisk to update root on that image, can I just dirty flash it to have up-to-date Magisk root? Just want to know before I (potentially) corrupt something 😭

ahnet-69 commented 1 year ago

Basically, if I download a system.img to my phone and get Magisk to update root on that image, can I just dirty flash it to have up-to-date Magisk root? Just want to know before I (potentially) corrupt something 😭

system image has nothing to do with magisk. you only patch your boot.img which survives gsi updates as it is left untouched

StupidRepo commented 1 year ago

Ah ok. How do I get the boot.img of latest GSI build then?

ahnet-69 commented 1 year ago

Ah ok. How do I get the boot.img of latest GSI build then?

oh my god 😭

Generic SYSTEM image has nothing to do with any other partitions other than system image partition. rest of your partitions are left untouched and the Generic SYSTEM image uses your stock stuff from there. There is no boot.img, vendor.img etc. shipped with Generic SYSTEM image.

For rooting you only patch your boot.img.and then flash the modified boot to your boot partition. It would survive even if you switched gsis since your not touching boot at all. i hope you understand

StupidRepo commented 1 year ago

Ohhhh! OK. Sorry, I understand now.