search

ahodges9 / LedFx

LedFx is a network based LED effect controller with support for advanced real-time audio effects! LedFx can control multiple devices and works great with cheap ESP8266 nodes allowing for cost effectvice syncronized effects across your entire house!
MIT License
384 stars 91 forks source link

Custom Colors / Gradients #157

Open ShiromMakkad opened 3 years ago

ShiromMakkad commented 3 years ago

I'd really like to create a rainbow gradient to use, but there's no option to create custom gradients. There's also no option to set custom colors.

I was looking through the code, and it's ridiculously well organized. I could very easily add this gradient into the program, and I could look at creating a gradient creator too. Would you be open to this?

Mattallmighty commented 3 years ago

Hi @ShiromMakkad,

Yes you are most welcome to add new effects. Effects are defined in ledfx\ledfx\effects I would also suggest to have a look at how the rainbow effect works for an idea of the pixel generation. https://github.com/ahodges9/LedFx/blob/dev/ledfx/effects/__init__.py Join our Discord LedFx server for general LedFx discussion and assistance via: https://discord.com/invite/wJ755dY

Once tested, do a pull request to: https://github.com/ahodges9/LedFx/tree/dev and comment on the Discord channel #dev_chat your pull URL.

Mattallmighty commented 3 years ago

There are two effects that look like what you are after, Gradient and Rainbow effect. Are you using https://ledfx.app/download/ version: LedFx 0.0.0.3? The latest version has presets, which allows you to save this effect configuration as a preset.

I think this is what you are referring to? image

ShiromMakkad commented 3 years ago

Thanks for the help, I've actually realized looking at the code that Spectral is the name for rainbow. Personally, I'd rename that to be more clear.

I still really like the project and codebase, and I've got a lot of React experience so I'd be happy to help out. Based on what you've said about the WLED effect here: https://github.com/ahodges9/LedFx/issues/47, I think that you want LedFX to be a universal controller for lots of RGB software, and I'd love to help with that. We could even potentially integrate with OpenRGB, so you can control all your PC peripherals with this too.

shauneccles commented 3 years ago

@ShiromMakkad agreed. We have renamed spectral to rainbow.

Your help would be appreciated! Integration with other projects is always nice - we have various senders at the moment, so integrating an i2c header control is possible, or utilizing OpenRGBs API.

We're going to try to squash some bugs.