ahopk127 / eecs2311-tab2xml

The project for Group 2 in EECS 2311 - 2021 Winter
GNU General Public License v3.0
1 stars 1 forks source link

Issue with output of Parser.parse() #12

Closed qurafa closed 3 years ago

qurafa commented 3 years ago

Version: 0.3.0

Platform: macOS Big Sur Version 11.0.1

Steps to reproduce:

Expected: The variable 'output' is properly assigned to p.parser()

Actual: The output of p.parser() could not be assigned to the String 'output'

Priority: Low-Since this bug doesn't affect the main purpose of the project, which is to generate a MusicXML equivalent of the tablature, and the bug doesn't stop it from doing that.

Severity: High-This is because the feature is one of the ones listed in the user manual of the project, so it has a high impact of the features of the project

Screenshot: image

ahopk127 commented 3 years ago

That feature is not intended. You are supposed to insert the text tab as a string (contents of the file), not a file or filepath (The backend code is not intended to interact with files at all). I will clarify that in the documentation.

ahopk127 commented 3 years ago

The documentation issue has been fixed on my feature branch. This change is expected to be present in the future version v0.4.0a2.

ahopk127 commented 3 years ago

About the error with the output: you need to put the statement in a try-catch block, that is why it is not working. This was stated in the original documentation but I also clarified that.