Rfc822DateParser is not thread safe

ahorn / android-rss

Lightweight Android library to parse RSS 2.0 feeds.

529 stars 176 forks source link

Rfc822DateParser is not thread safe #38

Closed xmaux72 closed 6 years ago

xmaux72 commented 7 years ago

Hi,

I'm using your library to read many rss feeds at a time. I noted strange dates in my articles and searching the code I noticed that:

/**

@see RFC 822 */ private static final SimpleDateFormat RFC822 = new SimpleDateFormat( "EEE, dd MMM yyyy HH:mm:ss Z", java.util.Locale.ENGLISH);

SimpleDateFormat is NON thread-safe so you can't declare as static https://stackoverflow.com/questions/6840803/why-is-javas-simpledateformat-not-thread-safe

Thanks for your great work.

ahorn commented 7 years ago

Hi @xmaux72. Thanks for the comment. I'd accept a pull request that fixes this issue. Is the other code thread-safe?

ahorn commented 7 years ago

Hi @xmaux72

For some time now, I wanted to update the README with some contributor information, and references to projects/products that are using android-rss. If you are willing to share any of this information, please feel free to provide the following, or a subset thereof:

Your name and/or organization you would like to be mentioned;
The project name, or product, that is using android-rss.

Many thanks again for your contributions!

xmaux72 commented 7 years ago

https://play.google.com/store/apps/details?id=it.btbmobile.InfoViolaFree and https://play.google.com/store/apps/details?id=it.btbmobile.infotoro

2 news aggregator about italian soccer teams.

feel free to share :)