search

ahornung / humanoid_navigation

ROS stack with footstep planning and localization for humanoid robots: http://wiki.ros.org/humanoid_navigation
37 stars 75 forks source link

STL hash to avoid int traps #9

Open efernandez opened 10 years ago

efernandez commented 10 years ago

With some flags, the program fails because of the integer operations. Furthermore, it looks reasonable to use the STL hash function, unless there's some reason to use the other.

efernandez commented 10 years ago

Pull request against hydro-devel branch. Closed #6

Sorry for the noise

ahornung commented 10 years ago

I think std::hash is also C++11 / tr1 only. Maybe there is a way to disable -ftrapv instead for the hashing code block?

efernandez commented 10 years ago

Yes, it's C++11. I'll have to check how to disable -ftrapv in my environment (I have to check where was the problem exactly). I don't know how we can do it in a general way (if something sets it).