search

ahoward / macaddr

cross platform mac address determination for ruby
Other
47 stars 41 forks source link

Restore systemu dependency #20

Closed hubert closed 10 years ago

hubert commented 10 years ago

This seems like the simplest way to modify the rake task to use the dependencies declared in the Mac module.

hubert commented 10 years ago

as alluded to, in the interests of simplicity, i've omitted a lot of the format checking since i wasn't clear on why it was necessary.

if anyone has insight on why it's preferable to have a rake task build your gemspec rather than create the gemspec by hand, i'd love to hear it.

yaauie commented 10 years ago

@hubert your patch looks cleaner than I expected, but it looks like it should solve the problem.

As to why prefer a 350+ line Rakefile and to manage the release of a 100-line gem: I personally see no reason. It appears as though @ahoward copy-pastes this Rakefile across all of his gems in an effort to standardize and genericize, but in my opinion it over-complicates something that is otherwise simple.

I got frustrated with mucking with the rake task and I forked this project, simplified the release chain, improved test coverage, and released a gem as mac-address (source).

ahoward commented 10 years ago

@yaauie that's a foolish/lazy thing to say. i manage many gems

http://rubygems.org/profiles/ahoward

doing things by hand isn't an option