Assign stable and human-friendly names to generated type names - Githubissues

ahrefs / atd

Static types for JSON APIs

Other

309 stars 52 forks source link

Assign stable and human-friendly names to generated type names #321

Closed mjambon closed 1 year ago

mjambon commented 1 year ago

This is a follow-up to yesterday's PR on which I commented: https://github.com/ahrefs/atd/pull/319#pullrequestreview-1176225840

The nicer type names are used:

internally in .ml files generated by atdgen. The name changes shouldn't affect the users since they're not part of the generated .mli` interfaces.
for Python class names resulting from monomorphization. Check out the changes in the generated file everything.py.

PR checklist

[x] New code has tests to catch future regressions
[x] Documentation is up-to-date
[x] CHANGES.md is up-to-date