ahrefs / atd

Static types for JSON APIs
Other
309 stars 52 forks source link

Uncaught syntax error when missing a " #326

Open schinns opened 1 year ago

schinns commented 1 year ago
type timestamp = string wrap <ocaml module=Dates.Timestamp">

I had this value in an atd file where I had missed the opening double quote. When building it produced the error:

$ dune build
Entering directory '/home/me/ahrefs/monorepo/backend'
File "aim/server/dune", line 17, characters 0-123:
17 | (rule
18 |   (targets servers_j.mli servers_j.ml)
19 |   (deps servers.atd)
20 |   (action (progn (run %{bin:atdgen} -j -j-std %{deps}))))
Fatal error: exception Atd.Parser.MenhirBasics.Error
File "aim/server/dune", line 22, characters 0-116:
22 | (rule
23 |   (targets servers_t.mli servers_t.ml)
24 |   (deps servers.atd)
25 |   (action (progn (run %{bin:atdgen} -t %{deps}))))
Fatal error: exception Atd.Parser.MenhirBasics.Error

The expected error should be to print error location (as it does with other syntax errors)