I've spotted a minor code inconsistency in atdgen-tutorial.rst, in the data-validation section. The test for validation was reversed, Some _ should indicate some errors were found, and None means validation passed (is_valid = true).
I've updated the test file to align with the code quoted in the doc, also changed a date which was out of sync (unimportant).
Thank you!
PR checklist
[x] New code has tests to catch future regressions
Not applicable, no new code.
[ ] Documentation is up-to-date
Successfully ran dune build @doc. Any other checks required?
Hello,
I've spotted a minor code inconsistency in
atdgen-tutorial.rst
, in the data-validation section. The test for validation was reversed,Some _
should indicate some errors were found, andNone
means validation passed (is_valid = true
).I've updated the test file to align with the code quoted in the doc, also changed a date which was out of sync (unimportant).
Thank you!
PR checklist
[x] New code has tests to catch future regressions Not applicable, no new code.
[ ] Documentation is up-to-date Successfully ran
dune build @doc
. Any other checks required?[x]
CHANGES.md
is up-to-date Not applicable.