search

ahrefs / atd

Static types for JSON APIs
Other
315 stars 52 forks source link

atdgen: add support for open_enum in melange #401

Closed tatchi closed 5 months ago

tatchi commented 7 months ago

This is my attempt at adding support for <json open_enum> in melange

Khady commented 6 months ago

what's the status here?

tatchi commented 6 months ago

I saw the additions to omelange_emit and the generated code are essentially copied from the native part? If so, I wonder if there's an opportunity to share more code across both implementations in the form of a new library, or something else.

I took inspiration from the native part, but I'm not sure if we can really share pieces of code. Anything particular you had in mind ?

what's the status here?

I think I've addressed all of @jchavarri's comments, so I think it should be good to merge.