ahrefs / ocannl

OCANNL: OCaml Compiles Algorithms for Neural Networks Learning
BSD 2-Clause "Simplified" License
67 stars 2 forks source link

An incompleteness bug deep inside shape inference, with a workaround hiding it for now #221

Closed lukstafi closed 10 months ago

lukstafi commented 10 months ago

The workaround is applying the solution found on re-generated constraints inside derive_projections, i.e. when solving for the 3rd time -- the relevant variables should be already solved during the 2nd pass i.e. inside finish_inference.

The whole setup will probably get refactored when I work on optimizing shape inference (it's doing a lot of work now).