Both `dim_constraint` and `row_constraint` (former `dims_constraint`) should be stored in entries

ahrefs / ocannl

OCANNL: OCaml Compiles Algorithms for Neural Networks Learning

BSD 2-Clause "Simplified" License

62 stars 2 forks source link

Both `dim_constraint` and `row_constraint` (former `dims_constraint`) should be stored in entries #249

Closed lukstafi closed 5 months ago

lukstafi commented 5 months ago

We avoided storing dims_constraint in entries but it's somewhat ugly and reduces expressivity. Also: modify the Total_elems constraint to include a divided_by : dim_var list field, to simplify row constraint propagation.

lukstafi commented 5 months ago

This got done soon after being reported.