search

ahrm / sioyek

Sioyek is a PDF viewer with a focus on textbooks and research papers
https://sioyek.info/
GNU General Public License v3.0
6.75k stars 219 forks source link

toggle_titlebar causes the window to vanish #1057

Open cmaspi opened 2 months ago

cmaspi commented 2 months ago

When I use toggle_titlebar the following happens image

I'm using the latest release from flatpak.

ahrm commented 2 months ago

I don't think I can fix this on sioyek's end (probably it is a window-manager specific thing), this probably should be fixed in Qt side.

Aman9das commented 2 months ago

Try this release: https://github.com/Aman9das/com.github.ahrm.sioyek/actions/runs/8679761337

And tell if the issue persists

cmaspi commented 2 months ago

@Aman9das it persists

Aman9das commented 2 months ago

Are you on Wayland? Try Xorg n check .

I have tried to reproduce, but unable to. kindly re-install and disable extensions..

Aman9das commented 2 months ago

Since wayland mandates Client side decoration. The toggle should be disabled on wayland. In my testing the titlebar isn't hidden afterall.

Regardless, @cmaspi the previous install may be causing issue, uninstall the previous install and kindly test the beta release afterwards..

fabiooo4 commented 2 months ago

I have this problem too, but in my case this happens only if i run toggle_titlebar using the command list after opening sioyek. If i run

$ sioyek --execute-command toggle_titlebar

or if i set toggle_titlebar as a startup command in prefs_user.config or in prefs.config everything works as expected.

cmaspi commented 2 months ago

@Aman9das On removing the stable version, toggle_titlebar doesn't cause the window to vanish but as you mentioned it does nothing. I'm fine with it since the beta release has a dark titlebar.

Running the command that @fabiooo4 suggested doesn't hide the titlebar for me.

I didn't check it on Xorg since I don't plan to switch to it anytime soon. Thanks for your support!

Aman9das commented 2 months ago

The white title bar is a result of Flatpak packaging method used, not sioyek itself. Kindly report the issue in the Flatpak manifest repo..

https://github.com/flathub/com.github.ahrm.sioyek