search

ahrm / sioyek

Sioyek is a PDF viewer with a focus on textbooks and research papers
https://sioyek.info/
GNU General Public License v3.0
6.75k stars 219 forks source link

Out-of-bounds access on color arrays #1092

Closed novelhawk closed 1 month ago

novelhawk commented 1 month ago

I believe I found an access out of bounds on both color arrays in the following line.

https://github.com/ahrm/sioyek/blob/b72c3e0e2c45d7094ac810d275a97d65763cd2e8/pdf_viewer/pdf_view_opengl_widget.cpp#L1914

Realistically this does not matter since the 4th channel is ignored and there are no risks of crashes/exploitation so feel free to close without fix if you don't feel like this warrants a fix.

ahrm commented 1 month ago

Should be fixed in https://github.com/ahrm/sioyek/commit/d5230d106c9c5040d376edece6a7347c9785d8bc.