Closed iamkroot closed 2 years ago
I am aware of this but in my opinion this is worth it because we can reuse the same renders for the preview and for the main view which leads to better performance and less memory consumption.
By the way, in recent versions you can resize the preview window so the blurring is less visible.
reuse the same renders for the preview and for the main view
That does sound useful, but probably better to have it as an configurable option? I really don't care about memory in most cases, and having it render twice isn't going to eat up my cpu.
in recent versions you can resize the preview window
Could you specify how to do this? I tried pressing -
when the overview is open, but that only resized the underlying page. Is there some config key for this?
I realized that the blurring is less apparent when the page is zoomed more than the overview width. So why not make the overview window width be in terms of the current page width, rather than the window width? (Also the overview would be centered on page center, rather than window center). This way, the text in overview would always be marginally smaller than the text in page.
Could you specify how to do this? I tried pressing - when the overview is open, but that only resized the underlying page. Is there some config key for this?
You can resize by dragging mouse on the borders of the overview window. Overview being the size of current page is a possible idea, however I don't think it is an important problem since the overview size is adjustable anyway. I probably will add an option so that the preview window is rendered at an appropriate resolution (at the cost of time and space).
Added a rerender_overview
option in 913b77c94a01d07502ef39911f3e95a21df83e73 which instructs sioyek to rerender the overview page at appropriate resolution. You have to add the following to your prefs_user.config
:
rerender_overview 1
Added a
rerender_overview
option in 913b77c which instructs sioyek to rerender the overview page at appropriate resolution. You have to add the following to yourprefs_user.config
:rerender_overview 1
Thanks a lot! It seems to be working great :)
You can resize by dragging mouse on the borders of the overview window
Hmm, I might be missing something, but as soon as I move my mouse when the hover overview is open, it closes the overview window. Is there something to keep it open so I can drag the borders?
Overview being the size of current page is a possible idea, however I don't think it is an important problem since the overview size is adjustable anyway
Is the overview size remembered across restarts/documents? What happens when different docs have different page sizes?
Hmm, I might be missing something, but as soon as I move my mouse when the hover overview is open, it closes the overview window. Is there something to keep it open so I can drag the borders?
Oh! You probably have hover_overview
enabled. If you want to be able to resize you should disable it by adding:
hover_overview 0
Now you can manually open overviews by right clicking on links.
Is the overview size remembered across restarts/documents? What happens when different docs have different page sizes? No it is not remembered. You have to reset it again and I don't think I will add the ability to save it because I want to keep database files as simple as possible.
you want to be able to resize you should disable it by adding
I guess that means I can't have hover overview enabled and be able to resize it at the same time (since the size isn't persisted, and we need to restart the app to be able to resize). Maybe a shortcut/command to toggle "hover_overview"? Or is it something that needs a restart?
I don't think I will add the ability to save it because I want to keep database files as simple as possible.
Yes, that makes sense, no point in storing this kind of info. However, this only strengthens the case for having the overview window's size as relative to the page size.
This seems like a good default for all documents, and would cover almost all cases where one would need to resize manually.
We have added the ability to store overview position a while back.
The Overview popup that is shown when hovering over a link seems to zoom the contents to fit the screen width. When the underlying page is not at "Fit Width" zoom level, this causes the overview to be blurred due to image resizing artifacts. For example, open the following image in a new tab to see this in action:
(Original page zoom was made exceptionally small to make the bug easily perceivable)
The fix would be to have the overview window render the page at the new zoom level that matches width of the window.
Extra Info: Sioyek version:
main
branch OS: Linux- Manjaro latest DE: KDE Plasma 5.23.4