search

ahrm / sioyek

Sioyek is a PDF viewer with a focus on textbooks and research papers
https://sioyek.info/
GNU General Public License v3.0
7.18k stars 236 forks source link

custom colors in preview release don't work like in the main branch #1193

Closed dinesh-58 closed 1 month ago

dinesh-58 commented 1 month ago

So I tried copying over my configs to the preview release build, which includes this in my pref_user.config:

custom_background_color 0.102 0.106 0.149
custom_text_color 0.753 0.792 0.961

So, let's say I open a pdf with some graphical elements / colors which normally looks like this: image Custom colors in main branch: image

Custom colors in preview release: image Note how the logo, borders & heading don't get the custom color applied, though the corner graphic seems to apply the color properly. Also, the area outside the pdf remains black instead of using custom_background_color. Let me know if I should send the pdf file here

ahrm commented 1 month ago

Yes, we try to better save the original colors when possible. We still use the exact configured color for text and background. I think the new colors look much better.

dinesh-58 commented 1 month ago

Oh ok. I'll try getting used to this then. Is there a way to set the color for the area outside the pdf?

ahrm commented 1 month ago

Yes, using custom_color_mode_empty_background_color config.

dinesh-58 commented 1 month ago

Thanks a lot. Seems this hasn't been documented in prefs.config or the docs site. Let me know if you need me to make a PR.