search

ahrm / sioyek

Sioyek is a PDF viewer with a focus on textbooks and research papers
https://sioyek.info/
GNU General Public License v3.0
7.2k stars 236 forks source link

Link to external pdf crashes sioyek #1199

Closed jrotheneder closed 1 month ago

jrotheneder commented 1 month ago

Opening a link in a pdf which leads to an external pdf in the same folder leads with the example files below to the error message "could not open /..../leA.pdf" [sic] and a subsequent crash. I'm using the pre-release version of sioyek from Sep. 11. The examples have been generated via LaTeX like in this stack exchange post.

fileA.pdf fileB.pdf

ahrm commented 1 month ago

Should be fixed in https://github.com/ahrm/sioyek/commit/07bb5f0da06423b544684fd3f7c136190090a106.

jrotheneder commented 1 month ago

That was fast, thanks! The linked pdf now opens, but not yet in the correct location.

With the two files above, clicking the link in fileB should open page 3 of fileA, but currently opens page 1. I've tested with other pdf readers to make sure this is not an issue with the pdfs themselves: Okular on Linux and PDF Expert on Mac display the correct behaviour.

ahrm commented 1 month ago

Should be fixed in https://github.com/ahrm/sioyek/commit/50b4de8e7d9e18df38d0e4f5b37d067e5f10d117.

jrotheneder commented 1 month ago

Can confirm, neat.