ahrm / sioyek

Sioyek is a PDF viewer with a focus on textbooks and research papers
https://sioyek.info/
GNU General Public License v3.0
7.06k stars 234 forks source link

text is too pixelated #639

Closed Aneeqasif closed 1 year ago

Aneeqasif commented 1 year ago

may be its beacuse i am using fractional scalling i dnt know but its unsabley blurry . please adress this issue

document viewer gnome

image

sioyek

image

ahrm commented 1 year ago

Does the issue still happen in the latest experimental builds here? https://github.com/hexomancer/sioyek/releases/tag/v0.31.431

Aneeqasif commented 1 year ago

yes the version u shared works well but there is also an issue that in this issue to table of content view look very outdated and not much polished desing while the toc selector in the version that i have (with pixelated text) has much more polished ui. please address this in a version that solve both issues

version with good text rendering but bad ui of toc

Screenshot_20230219_002001

verion with pixelated text rendering but with alot more polished and modern toc ui

Screenshot_20230219_001335

ahrm commented 1 year ago

There is no code change for table of contents rendering, so if it is changed between versions either it has changed because of changes in Qt (which I can't do anything about), or because of your configs.

Aneeqasif commented 1 year ago

right so which verion should i used the forked one or from ahrm/sioyek repo , shouldnt the pixelated issue be resolved in orignal sioyek verion ?

Aneeqasif commented 1 year ago

as the version u suggested in 5 comits behind so it might be missing some functionality from official verion

ahrm commented 1 year ago

right so which verion should i used the forked one or from ahrm/sioyek repo , shouldnt the pixelated issue be resolved in orignal sioyek verion ?

Probably the forked version. This issue will be fixed when we do a new release. At this point version 2.0.0 is a couple of months old so it is way more than 5 commits behind.

Aneeqasif commented 1 year ago

i tried buliding the orignal verion following the build instructions , and then run sioyek from build directory it ran perfectly as expected without any issue, but i dont know how to properly install it in system , i did sudo make install but when i try to run sioyek from m y menu system in kde sioyek doesnot run properly and it was not responding, then i ran $which sioyek and then /usr/bin/sioyek it showed same response as it open it from menu system some errors was on terminal like cannot find /usr/bin/shaders etc so , i have successfully build the orignal version that ran find but please help to properly install it system wide

ahrm commented 1 year ago

You can just create a symlink from /usr/bin to sioyek's executable.

Aneeqasif commented 1 year ago

right , but isnt there any proper way to do it for system wide installation

ahrm commented 1 year ago

That is the proper way.

Aneeqasif commented 1 year ago

That is the proper way.

ok so i tried this but one thing is not working that is cross document portal steps to i did open 2 docs press p on one doc press p again on other document then went back to first document and press f12 the portal didnt open in the showing part from 2nd doc in helper window (that remian blank black)

it worked just fine if i create a portal within same document

ahrm commented 1 year ago

Can't reproduce either of these issues. Do they occur with the build of latest commits here: https://github.com/hexomancer/sioyek/releases/tag/v0.31.432 ?

Aneeqasif commented 1 year ago

no i have tested it on version v0.31.431 that u suggested in previous comment

demo of statusbar toggle issue on startup and the portals issue in cross doc portal

https://user-images.githubusercontent.com/78728701/219967725-5a388256-723b-4765-99ae-907ee8bb6c8e.mp4

Aneeqasif commented 1 year ago

as u can see when i open 2 pdfs there was no statusbar on first one as expected and set in config, but in 2nd pdf the statusbar is there which shouldnt be there (then i toggled back the statusbar in 1st pdf with set keybind A-o to make both look same) and secondly i cannot create a portal from other pdf in first pdf

ahrm commented 1 year ago

Which command does open with sioyek execute?

Aneeqasif commented 1 year ago

Which command does open with sioyek execute?

it is opened by desktop file in which use /usr/bin/sioyek which is symlinked to the executable thats in build folder i have also tested it with the full direct path of the binary that i built

Aneeqasif commented 1 year ago

should i try it on virtual machine to further investigate?

ahrm commented 1 year ago

Can you share the desktop file here?

Aneeqasif commented 1 year ago

[Desktop Entry] Name=Sioyek Comment=PDF viewer for reading research papers and technical books Keywords=pdf;viewer;reader;research; TryExec=/home/aneeq/Downloads/Compressed/sioyekHamxe/build/sioyek Exec=/home/aneeq/Downloads/Compressed/sioyekHamxe/build/sioyek %f StartupNotify=true Terminal=false Type=Application Icon=sioyek-icon-linux Categories=Development;Viewer; MimeType=application/pdf;

Aneeqasif commented 1 year ago

Can you share the desktop file here?

you can see the desktop file in above comment

ahrm commented 1 year ago

The desktop file looks okay, unfortunately I am not able to reproduce the statusbar issue. Note that the portal issue is not really a bug, we don't have the ability to link between different sioyek windows yet, so if you want to create a portal to another document you have to use the same sioyek window to open the second document (I understand creating portals between windows is a useful feature and I will probably add it in the future.).

Aneeqasif commented 1 year ago

thanks for responding i really appreciate your time and effort

ahrm commented 1 year ago

Added the ability to create portals between windows in c8a532acbf87b57b9e58ec3367071db49dbb0433.

Aneeqasif commented 1 year ago

Added the ability to create portals between windows in c8a532a.

thats awesome :heart: