search

ahrm / sioyek

Sioyek is a PDF viewer with a focus on textbooks and research papers
https://sioyek.info/
GNU General Public License v3.0
6.97k stars 228 forks source link

Highlight highlights entire line for some pdfs #785

Closed DeonteVanterpool closed 7 months ago

DeonteVanterpool commented 1 year ago

I love the app. I works almost perfectly for what I have to do, but I have a PDF (attached below), which when I try to highlight specific words in the book, entire lines get highlighted. I don't have this issue with other apps like Xodo and All PDF Reader on my phone. AtomicHabits.pdf

I also have another PDF which allows me to highlight words in some places (page 59 "248 people"), but in other places (page 59 "first group"), it continues to highlight entire lines. PDF attached below: atomic-habits.pdf

Other PDFs seem to be working fine, so I'm guessing its something to do with how the PDF is formatted. I tried repairing the PDF using qpdf to no avail.

I am using arch linux by the way, and am using Sioyek version 2.0.0.

DeonteVanterpool commented 1 year ago

The workaround would be to set exact_highlight_select to 1

DeonteVanterpool commented 1 year ago

The workaround would be to set exact_highlight_select to 1

Update: The exact highlighting is not a good workaround, as when I reload the document, the exact highlights go back to line highlights.

zhizhongpu commented 1 year ago

I have a similar issue when I selected part of a sentence to highlight but the realized highlight includes part of the next sentence. image

zhizhongpu commented 1 year ago

as when I reload the document, the exact highlights go back to line highlights.

this also happens to me too.

ahrm commented 7 months ago

Should be fixed in https://github.com/ahrm/sioyek/commit/c12306b99be7940438e89745cb4c0391d7762677.