search

ahrtr / etcd-defrag

An easier to use and smarter etcd defragmentation tool
MIT License
84 stars 9 forks source link

Remove learner member from endpointsFromCluster #28

Closed git-yww closed 1 year ago

git-yww commented 1 year ago

Fix #26

ahrtr commented 1 year ago

a quick question, have you verified this PR in your test that you mentioned in https://github.com/ahrtr/etcd-defrag/issues/26#issuecomment-1766151933?

git-yww commented 1 year ago

a quick question, have you verified this PR in your test that you mentioned in #26 (comment)?

Yes，it did work.

ahrtr commented 1 year ago

please squash the commits into one.

git-yww commented 1 year ago

please squash the commits into one.

resolved

ahrtr commented 1 year ago

Can you please add an item under https://github.com/ahrtr/etcd-defrag#note something like below?

Please do not get learner members' endpoints included in `--endpoints`,  refer to discussion in https://github.com/ahrtr/etcd-defrag/issues/26.
git-yww commented 1 year ago

Absolutely. That's a good point.

git-yww commented 1 year ago

Due to that one etcd cluster only supports one learner member, so the item to add will be like: Please do not get learner member endpoint included in--endpoints, refer to discussion in https://github.com/ahrtr/etcd-defrag/issues/26.

ahrtr commented 1 year ago

The default maxLearner is 1, but actually it's configurable via the flag --experimental-max-learners, so let's use the plural noun.

ahrtr commented 1 year ago

Thanks again! Nice work!