ahungry / ahungry-fleece

Common Lisp minimalist utility library
GNU General Public License v3.0
7 stars 0 forks source link

Some systems failed to build for Quicklisp dist #2

Open quicklisp opened 1 year ago

quicklisp commented 1 year ago

Building with SBCL 2.3.1.43-c2e7dcbd6 / ASDF 3.3.5 for quicklisp dist creation.

Trying to build commit id 1cef1d3a3aa9cffe9f06b7632006565bbc986814

ahungry-fleece fails to build with the following error:

; caught WARNING:
;   The function SB-IMPL:WHITESPACE[2]P is called with one argument, but wants exactly two.
...
Unhandled UIOP/LISP-BUILD:COMPILE-FILE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1001720003}>: COMPILE-FILE-ERROR while compiling #<CL-SOURCE-FILE "ahungry-fleece" "af.contrib.sb-cover" "cover">

skeleton fails to build because of a failure in ahungry-fleece.

Full log here

ahungry commented 1 year ago

Thanks - sbcl made a backwards compatability breaking change here - I guess they don't use semantic versioning, because this is still fine on my 2.3.0 version (Arch Linux shipped):

https://github.com/sbcl/sbcl/commit/df6846ef14d09bf499bd79bab09c082d9916fc9b

Fix seems to be here https://github.com/sbcl/sbcl/commit/df6846ef14d09bf499bd79bab09c082d9916fc9b#diff-8e657bab840fe06f48cead18efb8fd04b0545295e0c1faa858ca26dec830af7a, as my "cover.lisp" is essentially a mirror of that file (public domain). I think I can just port those changes over in cover.lisp and things should still work with old versions, since the 2nd arg was always available (but optional).

ahungry commented 1 year ago

I think this should be good next build, change in 0ecd515

quicklisp commented 1 year ago

I don't think you can count on any compatibility for internal packages like sb-impl, backwards or forwards.

On Fri, Feb 3, 2023 at 4:44 PM Matthew Carter @.***> wrote:

I think this should be good next build, change in 0ecd515 https://github.com/ahungry/ahungry-fleece/commit/0ecd515cb76044f9def9ce82165fd89c479669f8

— Reply to this email directly, view it on GitHub https://github.com/ahungry/ahungry-fleece/issues/2#issuecomment-1416434753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLMMW5CVZY52CGY5UVDWVV32PANCNFSM6AAAAAAUOMKGRI . You are receiving this because you authored the thread.Message ID: @.***>

xach commented 1 year ago

Still no good - there's an implicit dependency on sb-md5. Log here: http://report.quicklisp.org/2023-02-05/failure-report/ahungry-fleece.html#ahungry-fleece

ahungry commented 1 year ago

Oh that was sloppy of me, sorry! I had renamed some imports in the past and overwrote those renames when pulling in the latest file. Fixing that part now....

ahungry commented 1 year ago

I think it should be good now, I'll keep an eye on the link for tonight's build (assuming I can adjust the URL)