search

ahungry / org-jira

Bring Jira and OrgMode together
680 stars 130 forks source link

Warnings in emacs 29 #330

Closed dustinfarris closed 1 year ago

dustinfarris commented 1 year ago

I'm not sure if this applies to emacs 28 as well, but got a bunch of feedback when starting emacs with --debug-init

⛔ Warning (comp): jiralib.el:84:2: Warning: Package cl is deprecated
⛔ Warning (comp): jiralib.el:109:12: Warning: defcustom for ‘jiralib-coding-system’ fails to specify type
⛔ Warning (comp): jiralib.el:175:2: Warning: custom-declare-variable `jiralib-wsdl-descriptor-url' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): jiralib.el:194:2: Warning: custom-declare-variable `jiralib-agile-page-size' docstring wider than 80 characters
⛔ Warning (comp): jiralib.el:209:2: Warning: custom-declare-variable `jiralib-worklog-import--filters-alist' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): jiralib.el:242:2: Warning: custom-declare-variable `jiralib-update-issue-fields-exclude-list' docstring wider than 80 characters
⛔ Warning (comp): jiralib.el:358:9: Warning: Case 'getStatuses will match ‘quote’.  If that’s intended, write (getStatuses quote) instead.  Otherwise, don’t quote ‘getStatuses’.
⛔ Warning (comp): jiralib.el:359:9: Warning: Case 'getIssueTypes will match ‘quote’.  If that’s intended, write (getIssueTypes quote) instead.  Otherwise, don’t quote ‘getIssueTypes’.
⛔ Warning (comp): jiralib.el:360:9: Warning: Case 'getSubTaskIssueTypes will match ‘quote’.  If that’s intended, write (getSubTaskIssueTypes quote) instead.  Otherwise, don’t quote ‘getSubTaskIssueTypes’.
⛔ Warning (comp): jiralib.el:361:9: Warning: Case 'getIssueTypesByProject will match ‘quote’.  If that’s intended, write (getIssueTypesByProject quote) instead.  Otherwise, don’t quote ‘getIssueTypesByProject’.
⛔ Warning (comp): jiralib.el:364:9: Warning: Case 'getUser will match ‘quote’.  If that’s intended, write (getUser quote) instead.  Otherwise, don’t quote ‘getUser’.
⛔ Warning (comp): jiralib.el:365:9: Warning: Case 'getVersions will match ‘quote’.  If that’s intended, write (getVersions quote) instead.  Otherwise, don’t quote ‘getVersions’.
⛔ Warning (comp): jiralib.el:368:9: Warning: Case 'getWorklogs will match ‘quote’.  If that’s intended, write (getWorklogs quote) instead.  Otherwise, don’t quote ‘getWorklogs’.
⛔ Warning (comp): jiralib.el:371:9: Warning: Case 'addWorklog will match ‘quote’.  If that’s intended, write (addWorklog quote) instead.  Otherwise, don’t quote ‘addWorklog’.
⛔ Warning (comp): jiralib.el:376:9: Warning: Case 'updateWorklog will match ‘quote’.  If that’s intended, write (updateWorklog quote) instead.  Otherwise, don’t quote ‘updateWorklog’.
⛔ Warning (comp): jiralib.el:381:9: Warning: Case 'addWorklogAndAutoAdjustRemainingEstimate will match ‘quote’.  If that’s intended, write (addWorklogAndAutoAdjustRemainingEstimate quote) instead.  Otherwise, don’t quote ‘addWorklogAndAutoAdjustRemainingEstimate’.
⛔ Warning (comp): jiralib.el:386:9: Warning: Case 'addComment will match ‘quote’.  If that’s intended, write (addComment quote) instead.  Otherwise, don’t quote ‘addComment’.
⛔ Warning (comp): jiralib.el:390:9: Warning: Case 'createIssue will match ‘quote’.  If that’s intended, write (createIssue quote) instead.  Otherwise, don’t quote ‘createIssue’.
⛔ Warning (comp): jiralib.el:399:9: Warning: Case 'createIssueWithParent will match ‘quote’.  If that’s intended, write (createIssueWithParent quote) instead.  Otherwise, don’t quote ‘createIssueWithParent’.
⛔ Warning (comp): jiralib.el:406:9: Warning: Case 'editComment will match ‘quote’.  If that’s intended, write (editComment quote) instead.  Otherwise, don’t quote ‘editComment’.
⛔ Warning (comp): jiralib.el:410:9: Warning: Case 'getBoard will match ‘quote’.  If that’s intended, write (getBoard quote) instead.  Otherwise, don’t quote ‘getBoard’.
⛔ Warning (comp): jiralib.el:411:9: Warning: Case 'getBoards will match ‘quote’.  If that’s intended, write (getBoards quote) instead.  Otherwise, don’t quote ‘getBoards’.
⛔ Warning (comp): jiralib.el:412:9: Warning: Case 'getComment will match ‘quote’.  If that’s intended, write (getComment quote) instead.  Otherwise, don’t quote ‘getComment’.
⛔ Warning (comp): jiralib.el:416:9: Warning: Case 'getComments will match ‘quote’.  If that’s intended, write (getComments quote) instead.  Otherwise, don’t quote ‘getComments’.
⛔ Warning (comp): jiralib.el:420:9: Warning: Case 'getAttachmentsFromIssue will match ‘quote’.  If that’s intended, write (getAttachmentsFromIssue quote) instead.  Otherwise, don’t quote ‘getAttachmentsFromIssue’.
⛔ Warning (comp): jiralib.el:424:9: Warning: Case 'getComponents will match ‘quote’.  If that’s intended, write (getComponents quote) instead.  Otherwise, don’t quote ‘getComponents’.
⛔ Warning (comp): jiralib.el:426:9: Warning: Case 'getIssue will match ‘quote’.  If that’s intended, write (getIssue quote) instead.  Otherwise, don’t quote ‘getIssue’.
⛔ Warning (comp): jiralib.el:428:9: Warning: Case 'getIssuesFromBoard will match ‘quote’.  If that’s intended, write (getIssuesFromBoard quote) instead.  Otherwise, don’t quote ‘getIssuesFromBoard’.
⛔ Warning (comp): jiralib.el:432:9: Warning: Case 'getSprintsFromBoard will match ‘quote’.  If that’s intended, write (getSprintsFromBoard quote) instead.  Otherwise, don’t quote ‘getSprintsFromBoard’.
⛔ Warning (comp): jiralib.el:433:9: Warning: Case 'getIssuesFromSprint will match ‘quote’.  If that’s intended, write (getIssuesFromSprint quote) instead.  Otherwise, don’t quote ‘getIssuesFromSprint’.
⛔ Warning (comp): jiralib.el:437:9: Warning: Case 'getIssuesFromJqlSearch will match ‘quote’.  If that’s intended, write (getIssuesFromJqlSearch quote) instead.  Otherwise, don’t quote ‘getIssuesFromJqlSearch’.
⛔ Warning (comp): jiralib.el:443:9: Warning: Case 'getPriorities will match ‘quote’.  If that’s intended, write (getPriorities quote) instead.  Otherwise, don’t quote ‘getPriorities’.
⛔ Warning (comp): jiralib.el:445:9: Warning: Case 'getProjects will match ‘quote’.  If that’s intended, write (getProjects quote) instead.  Otherwise, don’t quote ‘getProjects’.
⛔ Warning (comp): jiralib.el:446:9: Warning: Case 'getProjectsNoSchemes will match ‘quote’.  If that’s intended, write (getProjectsNoSchemes quote) instead.  Otherwise, don’t quote ‘getProjectsNoSchemes’.
⛔ Warning (comp): jiralib.el:449:9: Warning: Case 'getResolutions will match ‘quote’.  If that’s intended, write (getResolutions quote) instead.  Otherwise, don’t quote ‘getResolutions’.
⛔ Warning (comp): jiralib.el:451:9: Warning: Case 'getAvailableActions will match ‘quote’.  If that’s intended, write (getAvailableActions quote) instead.  Otherwise, don’t quote ‘getAvailableActions’.
⛔ Warning (comp): jiralib.el:456:9: Warning: Case 'getFieldsForAction will match ‘quote’.  If that’s intended, write (getFieldsForAction quote) instead.  Otherwise, don’t quote ‘getFieldsForAction’.
⛔ Warning (comp): jiralib.el:465:9: Warning: Case 'progressWorkflowAction will match ‘quote’.  If that’s intended, write (progressWorkflowAction quote) instead.  Otherwise, don’t quote ‘progressWorkflowAction’.
⛔ Warning (comp): jiralib.el:469:9: Warning: Case 'getUsers will match ‘quote’.  If that’s intended, write (getUsers quote) instead.  Otherwise, don’t quote ‘getUsers’.
⛔ Warning (comp): jiralib.el:472:9: Warning: Case 'updateIssue will match ‘quote’.  If that’s intended, write (updateIssue quote) instead.  Otherwise, don’t quote ‘updateIssue’.
⛔ Warning (comp): jiralib.el:632:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): jiralib.el:814:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): jiralib.el:837:38: Warning: ‘subseq’ is an obsolete function (as of 27.1); use ‘cl-subseq’ instead.
⛔ Warning (comp): jiralib.el:944:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): jiralib.el:1092:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): jiralib.el:1112:33: Warning: reference to free variable ‘org-jira-users’
⛔ Warning (comp): jiralib.el:1124:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): jiralib.el:1124:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): jiralib.el:837:38: Warning: the function ‘subseq’ might not be defined at runtime.
⛔ Warning (comp): jiralib.el:757:50: Warning: the function ‘org-jira-decode’ is not known to be defined.
⛔ Warning (comp): jiralib.el:412:21: Warning: the function ‘org-jira-find-value’ is not known to be defined.
⛔ Warning (comp): org-jira.el:129:2: Warning: Package cl is deprecated
⛔ Warning (comp): org-jira-sdk.el:76:41: Warning: Non-symbol arguments to cl-defgeneric: (rec org-jira-sdk-record)
⛔ Warning (comp): org-jira-sdk.el:89:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira-sdk.el:166:15: Warning: the function ‘org-jira-decode’ is not known to be defined.
⛔ Warning (comp): org-jira.el:253:12: Warning: defcustom for ‘org-jira-use-status-as-todo’ fails to specify type
⛔ Warning (comp): org-jira.el:288:2: Warning: custom-declare-variable `org-jira-priority-to-org-priority-omit-default-priority' docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:627:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:637:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:659:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): org-jira.el:671:53: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.
⛔ Warning (comp): org-jira.el:680:6: Warning: ‘org-set-tags’ called with 2 arguments, but accepts only 1
⛔ Warning (comp): org-jira.el:681:31: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.
⛔ Warning (comp): Warning: assignment to free variable ‘p’
⛔ Warning (comp): org-jira.el:701:30: Warning: reference to free variable ‘p’
⛔ Warning (comp): org-jira.el:847:19: Warning: Unused lexical variable `n'
⛔ Warning (comp): org-jira.el:936:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:941:22: Warning: ‘concatenate’ is an obsolete function (as of 27.1); use ‘cl-concatenate’ instead.
⛔ Warning (comp): org-jira.el:1040:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:1139:16: Warning: ‘org-set-tags-to’ is an obsolete function (as of 9.2); use ‘org-set-tags’ instead.
⛔ Warning (comp): org-jira.el:1215:4: Warning: ‘org-show-all’ is an obsolete function (as of 9.6); use ‘org-fold-show-all’ instead.
⛔ Warning (comp): org-jira.el:1272:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:1331:66: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.
⛔ Warning (comp): org-jira.el:1401:10: Warning: ‘jiralib-update-worklog’ called with 1 argument, but requires 5 or 6
⛔ Warning (comp): org-jira.el:1468:44: Warning: Stray ‘declare’ form: (declare (ignore cb-data))
⛔ Warning (comp): org-jira.el:1553:33: Warning: Unused lexical variable `mimeType'
⛔ Warning (comp): org-jira.el:1556:33: Warning: ‘looking-back’ called with 1 argument, but requires 2 or 3
⛔ Warning (comp): org-jira.el:1797:11: Warning: Unused lexical variable `project-components'
⛔ Warning (comp): org-jira.el:1831:11: Warning: Unused lexical variable `parent-id'
⛔ Warning (comp): org-jira.el:1962:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:2093:23: Warning: Unused lexical variable `data'
⛔ Warning (comp): org-jira.el:2096:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): org-jira.el:2110:13: Warning: Unused lexical variable `cb-data'
⛔ Warning (comp): org-jira.el:2165:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:2202:2: Warning: docstring wider than 80 characters
⛔ Warning (comp): org-jira.el:2258:13: Warning: Unused lexical variable `cb-data'
⛔ Warning (comp): org-jira.el:2295:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): org-jira.el:2371:15: Warning: Unused lexical argument `status'
⛔ Warning (comp): org-jira.el:2422:2: Warning: ‘org-add-link-type’ is an obsolete function (as of 9.0); use ‘org-link-set-parameters’ instead.
⛔ Warning (comp): org-jira.el:2583:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
⛔ Warning (comp): org-jira.el:1503:39: Warning: the function ‘org-inlinetask-outline-regexp’ is not known to be defined.
⛔ Warning (comp): org-jira.el:1086:16: Warning: the function ‘org-element-at-point’ is not known to be defined.
⛔ Warning (comp): org-jira.el:941:22: Warning: the function ‘concatenate’ might not be defined at runtime.

are any of these worth addressing? i'd be happy to help contribute if it looks like a good use of time.

ahungry commented 1 year ago

I think you may be seeing the output of native-comp, which produces a lot of the warnings as a result of compilation which happens automatically (which otherwise you may have only seen with byte-compile called explicitly).

Most (all?) of these are simply warnings/syntax things equivalent to linter complaints (docstring line too long, unused var etc.) and not impactful to functionality.

If org-jira was applying for MELPA, these warnings would probably preclude it from being accepted, however it has been on MELPA (in this state) for a long time, at least 5+ years before I took over maintenance in 2015 (so, as-is for nearly 15 years).

It might be nice to address for any readability benefits, but any refactor brings risk of adding regressions - I would not personally spend the time on the changes myself, but PRs are always welcome.